Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Simple API #65

Closed
wants to merge 7 commits into from
Closed

Switch to Simple API #65

wants to merge 7 commits into from

Conversation

ryanking13
Copy link
Member

This PR works, but it is for now blocked by: #62 (comment)

@rth
Copy link
Member

rth commented Jun 30, 2023

So what do you think we should about this @ryanking13 ? Do you think we could maybe add Sample API support while keeping current behavior for PyPI for now, or that would be too complex? I mean it does sound like there could be some fastly cache related improvements pypi/warehouse#12214 (comment) but I don't really understand how blocking this situation currently is.

@ryanking13
Copy link
Member Author

ryanking13 commented Jun 30, 2023

@rth Nice timing. I was about to start working on this PR again.

Do you think we could maybe add Sample API support while keeping current behavior for PyPI for now, or that would be too complex?

I think we can go with supporting both Simple and legacy JSON API, (hopefully) it won't be very complex.

I mean it does sound like there could be some fastly cache related improvements pypi/warehouse#12214 (comment) but I don't really understand how blocking this situation currently is.

I think now the cache issue is okay. I mean fastly issue is still not resolved, but I believe now all Simple JSON responses in PyPI contains the CORS header correctly, so we can use it in micropip.

@ryanking13
Copy link
Member Author

Continued on #75.

@ryanking13 ryanking13 closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants