-
Notifications
You must be signed in to change notification settings - Fork 312
Apply Pyodide-specific patches to our Emscripten toolchain installation #2800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
agriyakhetarpal
merged 5 commits into
pypa:main
from
agriyakhetarpal:apply-pyodide-patches-to-emscripten
Apr 3, 2026
+31
−24
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bbb6722
Apply Pyodide's patches to Emscripten
agriyakhetarpal 45c1223
Quote the patch dir
agriyakhetarpal 9dc1940
Rework: remove manual patches, use `install-emscripten`
agriyakhetarpal c8d0766
Fix weird Emscripten version mismatch error due to symlink
agriyakhetarpal 2d7658d
Remove comment that's no longer needed
agriyakhetarpal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have some level of Windows support in pyodide-build, but not yet in cibuildwheel, so I stayed with the
catandpatchcommands here. We could think of a cross-platform solution later.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We never considered windows as a valid target so I think it is fine.