Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ${{ github.action_path }} to ${GITHUB_ACTION_PATH} #304

Draft
wants to merge 29 commits into
base: unstable/v1
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
803a86e
change ${{ github.action_path }} to $GITHUB_ACTION_PATH
sroet Nov 19, 2024
250ba4a
fix pre-commit not running in github web editor
sroet Nov 19, 2024
0b641b1
Enable variable interpolation in path to `create-docker-action.py`
webknjaz Nov 25, 2024
56811ce
experiment! container @ CI matrix
webknjaz Dec 8, 2024
d1fa8f5
experiment! 3.13
webknjaz Dec 8, 2024
b326013
bump! setuptools -> 75
webknjaz Dec 8, 2024
99746c4
comment! no container
webknjaz Dec 8, 2024
7804f57
Install GCC
webknjaz Dec 8, 2024
73f894c
Revert "Install GCC"
webknjaz Dec 8, 2024
4fb9074
experiment! prefer binary
webknjaz Dec 8, 2024
24ee19a
Revert "experiment! 3.13"
webknjaz Dec 8, 2024
5af3582
Install cargo
webknjaz Dec 8, 2024
6f3937f
debug! optional apt
webknjaz Dec 8, 2024
00335c8
debug! Container detection
webknjaz Dec 8, 2024
8e03b13
debug! localhost devpi
webknjaz Dec 8, 2024
a46ca5d
debug! devpi port
webknjaz Dec 8, 2024
03dbd39
Revert "debug! devpi port"
webknjaz Dec 8, 2024
7b54446
experiment! container-dependent URL
webknjaz Dec 8, 2024
c230da7
experiment! ubuntu
webknjaz Dec 8, 2024
9410b1e
Revert "experiment! ubuntu"
webknjaz Dec 8, 2024
d1b903e
debug! bash
webknjaz Dec 8, 2024
2d46385
Revert "debug! bash"
webknjaz Dec 8, 2024
799f862
Reapply "experiment! ubuntu"
webknjaz Dec 8, 2024
9967cd6
experiment! python
webknjaz Dec 8, 2024
e27955e
debug! pip
webknjaz Dec 8, 2024
afb72d9
debug! user install
webknjaz Dec 8, 2024
de68b37
experiment! setup-python
webknjaz Dec 8, 2024
3303c42
debug! py3
webknjaz Dec 8, 2024
dd1788e
debug! twine via runpy
webknjaz Dec 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 29 additions & 5 deletions .github/workflows/reusable-smoke-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,16 @@ jobs:

smoke-test:

strategy:
matrix:
container:
- '' # empty string == no container
- ubuntu:latest

runs-on: ubuntu-latest

container: ${{ matrix.container }}

services:
devpi:
image: muccg/devpi
Expand All @@ -70,8 +78,18 @@ jobs:
uses: actions/checkout@v4
with:
path: test
- name: Install the OS-level tools
if: >-
matrix.container != ''
run: >-
apt update --yes &&
apt install --yes cargo
- name: Ensure Python is there
uses: actions/setup-python@v5
with:
python-version: 3.x
- name: Install the packaging-related tools
run: python3 -m pip install build twine
run: python3 -m pip install build twine --prefer-binary --user
env:
PIP_CONSTRAINT: test/requirements/runtime.txt
- name: Create the stub package importable directory
Expand All @@ -86,7 +104,7 @@ jobs:
CONTENTS: |
[build-system]
requires = [
"setuptools == 65.6.3",
"setuptools == 75.6.0",
]
build-backend = "setuptools.build_meta"

Expand Down Expand Up @@ -119,14 +137,20 @@ jobs:
for dist in dist/*.tar.gz
do
echo "Registering ${dist}..."
twine register "${dist}"
python3 -m twine register "${dist}"
done
env:
TWINE_USERNAME: ${{ env.devpi-username }}
TWINE_PASSWORD: ${{ env.devpi-password }}
TWINE_REPOSITORY_URL: >-
http://localhost:${{
job.services.devpi.ports[env.devpi-port]
http://${{
matrix.container == ''
&& 'localhost'
|| 'devpi'
}}:${{
matrix.container == ''
&& job.services.devpi.ports[env.devpi-port]
|| env.devpi-port
}}/${{
env.devpi-username
}}/public/
Expand Down
5 changes: 4 additions & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,10 @@ runs:
steps.pre-installed-python.outputs.python-path == ''
&& steps.new-python.outputs.python-path
|| steps.pre-installed-python.outputs.python-path
}} '${{ github.action_path }}/create-docker-action.py'
}} "${GITHUB_ACTION_PATH}"/create-docker-action.py
# Use proposed workaround for ${{ github.action_path }} not working
# inside containers
# https://github.com/actions/runner/issues/2185#issuecomment-1683545859
env:
REF: ${{ steps.set-repo-and-ref.outputs.ref }}
REPO: ${{ steps.set-repo-and-ref.outputs.repo }}
Expand Down
Loading