-
Notifications
You must be signed in to change notification settings - Fork 265
Add compatibility for Pyodide-tagged wheels #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We are changing our wheel platform tag to pyodide_2024_0 so we need to teach packaging to map Emscripten platform to this.
@mayeut @henryiii @pradyunsg would appreciate review on this from any of you (and running the workflow). |
Tests and coverage check now pass locally for me. |
I stumbled into this PR, somehow – I guess the tests are valid for only Python 3.12 and should be skipped for other Python versions, @hoodmane? |
Now, we also pre-emptively need |
+1 - it would be great if packaging installed from PyPi would just work out of the box in Pyodide |
I guess the only remaining parts here are to generalise the ABI tags, so that |
We are changing our wheel platform tag to pyodide_2024_0 so we need to teach packaging to map Emscripten platform to this.
cc @henryiii