Skip to content

Add compatibility for Pyodide-tagged wheels #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hoodmane
Copy link

We are changing our wheel platform tag to pyodide_2024_0 so we need to teach packaging to map Emscripten platform to this.

cc @henryiii

@hoodmane hoodmane changed the title Add Pyodide compatibility Add compatibility for Pyodide-tagged wheels May 21, 2024
We are changing our wheel platform tag to pyodide_2024_0 so we need to teach
packaging to map Emscripten platform to this.
@hoodmane hoodmane marked this pull request as ready for review June 7, 2024 02:05
@hoodmane
Copy link
Author

hoodmane commented Jun 7, 2024

@mayeut @henryiii @pradyunsg would appreciate review on this from any of you (and running the workflow).

@hoodmane
Copy link
Author

Tests and coverage check now pass locally for me.

@agriyakhetarpal
Copy link

I stumbled into this PR, somehow – I guess the tests are valid for only Python 3.12 and should be skipped for other Python versions, @hoodmane?

@agriyakhetarpal
Copy link

Now, we also pre-emptively need 2025_0 as we broke/will be breaking the ABI.

@juntyr
Copy link

juntyr commented Feb 19, 2025

+1 - it would be great if packaging installed from PyPi would just work out of the box in Pyodide

@agriyakhetarpal
Copy link

I guess the only remaining parts here are to generalise the ABI tags, so that emscripten_x_y_zw and pyodide_abcd_e, where $$x, y, z, w, a, b, c, d, e ∈ [0, 9] $$ work, and skip the tests on unsupported Python versions (by probably grabbing the Python version from pyodide config get python_version)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants