Cache construction of name and version strings #12316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
commented
Oct 4, 2023
|
This would have to be submitted to |
bdraco
added a commit
to bdraco/packaging
that referenced
this pull request
Oct 4, 2023
extracted from pypa/pip#12316
This was referenced Oct 4, 2023
bdraco
added a commit
to bdraco/packaging
that referenced
this pull request
Oct 4, 2023
extracted from pypa/pip#12316
|
packaging PR was rejected pypa/packaging#726 so I'm going to close this PR At this point, I think the solution is it throw hardware at the problem |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12314
The install finishes in minutes instead of hours after this change.
I'm not sure ifpackagingshould be patched, or if I should open a PR to https://github.com/pypa/packaging so I'm looking for a bit of guidance on that.needs pypa/packaging#726