-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ruff to v0.3.6 #12595
Merged
Merged
Update ruff to v0.3.6 #12595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
requested changes
Mar 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One blocking issue in __pip-runner__.py
and two minor comments from my side.
notatallshaw
force-pushed
the
update-ruff-to-v0.3.4
branch
from
March 24, 2024 19:32
cf8654d
to
f990d94
Compare
sbidoul
approved these changes
Mar 25, 2024
notatallshaw
force-pushed
the
update-ruff-to-v0.3.4
branch
from
April 9, 2024 17:22
f990d94
to
046ff77
Compare
Updated to 0.3.5 and rebased, no issues found. |
Closed
notatallshaw
force-pushed
the
update-ruff-to-v0.3.4
branch
from
April 13, 2024 01:13
046ff77
to
557a1ce
Compare
Updated to 0.3.6 and rebased, no issues found. |
notatallshaw
force-pushed
the
update-ruff-to-v0.3.4
branch
from
April 13, 2024 01:14
557a1ce
to
f633c5d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating ruff to v0.3.4 caused two rules to fail, and fixing them caused a third one to fail:
.format
, previously this rule was not applied if it would cause the string to exceed the maximum line length, it was decided to change this behavior: [pyupgrade
] Allow fixes for f-string rule regardless of line length (UP032
) astral-sh/ruff#10263The other option would be to remove UP032 from the ruff rule selection.