tests: Use script.scratch_path over script.temp_path #13272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
script.temp_path is the system temporary directory. scripttest will check that there aren't any dangling files left in there, thus it's inappropriate to write long-lived packages there. These tests are currently passing as scripttest's temporary file detection logic is broken. However, a newer version of scripttest will fail.
ichard26
added
the
skip news
|
Merging as this can't possibly be controversial as a test-only change and I'd like to cut a new scripttest release later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
script.temp_pathis the system temporary directory. scripttest will check that there aren't any dangling files left in there, thus it's inappropriate to write long-lived packages there.These tests are currently passing as scripttest's temporary file detection logic is broken. However, a newer version of scripttest will fail.
(I'm currently in the midst of modernizing scripttest in preparation for some limited feature development.)