Better way to run slow linters in CI only#9504
Merged
Merged
Conversation
Member
sbidoul
commented
Jan 24, 2021
- update pre-commit hooks
- a better implementation of Improve local pre-commit experience #9333, taking advantage of pre-commit manual hook stages
Taking advantage of pre-commit's manual stage.
Member
Author
|
Sooo... what part of the universe changed so we suddenly have tests failing with |
Member
|
pypa/setuptools#2544 -- setuptools got rid of |
Member
Author
|
Good. So I guess we can stop testing that we correctly uninstall stuff installed with easy_install ? |
Member
|
I think we still should test against I was going to ask, does this change mean I can run |
Member
Author
I was not aware of that issue, but yes, it does :) |
pradyunsg
approved these changes
Jan 26, 2021
This was referenced Mar 8, 2021
This was referenced Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.