Handle setup.py possibly using sys.exit
#3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for the PR @arcivanov. I rebased the code on top of the |
arcivanov
force-pushed
the
issue_3973
branch
4 times, most recently
from
2894deb
to
e3131c9
Compare
Since `setup.py` is an arbitrary Python script legacy scripts may be complex and may use `sys.exit`. To adhere to PEP 517 handle `SystemExit` exception by ignoring it with exit code `0` and converting it to `CalledProcessError(exit_code, 'setup.py')` in case of non-zero exit code. fixes pypa#3973
In the case `SystemExit(0)` is generated to indicate success, we just emit a deprecation error (the dev is writing `setup.py` as if it was a CLI script, instead of a configuration-only file).
|
Hi @arcivanov, to avoid back and forth in the review I added a commit implementing the outcome of the issue discussion and I tried to reduce the number of tests being executed ( I hope that is OK with you (otherwise, please feel free to revert the commits and do something different). |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Since
setup.pyis an arbitrary Python script legacy scripts my be complex and may usesys.exit.To adhere to PEP 517 handle
SystemExitexception by ignoring it with exit code0and converting it toCalledProcessError(exit_code, 'setup.py')in case of non-zero exit code.fixes #3973
Pull Request Checklist
newsfragments/].(See [documentation][PR docs] for details)