fix(admin): accept multiple selected releases in malware reports#20236
Open
nnja wants to merge 1 commit into
Open
fix(admin): accept multiple selected releases in malware reports#20236nnja wants to merge 1 commit into
nnja wants to merge 1 commit into
Conversation
If two or more releases are selected for quarantine or deletion, submitting the form results in a 400 due to the duplicate POST keys check in `reject_duplicate_post_keys_view`. Change `permit_duplicate_post_keys` to accept either `True` (allow all keys) or an allow list. Change both verdict views to allow duplicate `versions` but reject other duplicated keys. Signed-off-by: Nina Zakharenko <nzakharenko@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20235 for both release quarantine and release deletion, taking a slightly different approach than #20222.
With the understanding that this may be a larger change than desired, given the change touches
warehouse/config.py.@miketheman let me know what you think. I'm looking for feedback and insight into what's preferred for Warehouse.