Revise network creation #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davide-f
reviewed
Apr 9, 2024
| ).set_axis(["bus0", "x0", "y0", "bus1", "x1", "y1"], axis=1) | ||
|
|
||
| lines_df["length"] = lines_df.apply( | ||
| lambda x: geodistance.geodesic((x["x0"], x["y0"]), (x["x1"], x["y1"])).meters |
There was a problem hiding this comment.
Do we need geopy for this?
An alternative is to make lines a geodataframe and use metric_crs to calculate the length
|
Closing as still covered in the code 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26 .
Changes proposed in this Pull Request
The goal is to make the workflow fetch the load and generation properly (currently there seems to be some issues there due to some temporal fix). Apart of that, it could probably make sense to revise a bit the current implementation.
Checklist
config.default.yamlandconfig.tutorial.yaml.test/(note tests are changing the config.tutorial.yaml)doc/configtables/*.csvand line references are adjusted indoc/configuration.rstanddoc/tutorial.rst.doc/release_notes.rstis amended in the format of previous release notes, including reference to the requested PR.