Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize_Emre_PR #56

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Margherita-Capitani
Copy link
Contributor

I took the super work done by @Emre-Yorat89 to enable automated downloading of building data and added some proposed Fixes to fix some of the problems in the original version.

Some comments:

  • The generated “all_raw_building” file is a geojson so as to maintain a functional structure for the rest of the code.
  • For now I commented out the part that allows a different file for each microgrid, because the later parts of the code are not yet up to date on this. This way the code works ( at least locally). At a later time, we can remove the comments and use the structure that Emre has already written :D

Locally it was tested on the tutorial case and it works, thanks @Emre-Yorat89 of the great work :D

@davide-f davide-f marked this pull request as ready for review November 27, 2024 14:45
Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello :D Add the release note :D Great team working :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants