Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Electricity Tutorial #1359

Merged
merged 10 commits into from
Feb 25, 2025

Conversation

GbotemiB
Copy link
Collaborator

@GbotemiB GbotemiB commented Feb 24, 2025

Closes #1340 (if applicable).

Changes proposed in this Pull Request

This PR aims to modify the electricity tutorial section. This PR also include a copy button feature into the documentation for code blocks.

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@GbotemiB GbotemiB force-pushed the revise-documentation branch from 9a06ef0 to 7213c12 Compare February 24, 2025 12:46
@GbotemiB GbotemiB force-pushed the revise-documentation branch from 6cc6206 to b147ae6 Compare February 24, 2025 12:54
@GbotemiB GbotemiB marked this pull request as ready for review February 24, 2025 13:03
@GbotemiB GbotemiB requested review from ekatef and davide-f February 24, 2025 13:04
Copy link
Member

@ekatef ekatef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @GbotemiB, looks like a great improvement!
Have added a small questions related to the change in the tutorial config. Could you please have a look? Otherwise, looks awesome 😄

Copy link
Member

@ekatef ekatef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect @GbotemiB! Thanks a lot for the explanations 😄
I think the PR is ready to be merged

Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @GbotemiB :D Many thanks for tackling the revision of electricity only! Thanks katia for the revision!
More than matches the goal!
Merging

@davide-f davide-f merged commit 1d395a0 into pypsa-meets-earth:main Feb 25, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise short tutorial- electric
3 participants