Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/re-enable quoted_insert: use self.evt.data #17

Merged
merged 2 commits into from
Aug 15, 2019

Conversation

blueyed
Copy link
Collaborator

@blueyed blueyed commented Aug 15, 2019

Reverts a59f338cc7b6c.

Fixes:

  File "/usr/lib/python3.7/cmd.py", line 126, in cmdloop
    line = input(self.prompt)
  File "…/src/pyrepl/pyrepl/readline.py", line 229, in raw_input
    ret = reader.readline(startup_hook=self.startup_hook)
  File "…/src/pyrepl/pyrepl/reader.py", line 605, in readline
    self.handle1()
  File "…/src/pyrepl/pyrepl/reader.py", line 588, in handle1
    self.do_cmd(cmd)
  File "…/src/pyrepl/pyrepl/reader.py", line 535, in do_cmd
    cmd.do()
  File "…/src/pyrepl/pyrepl/commands.py", line 373, in do
    r.insert((self.event + r.console.getpending().data) * r.get_arg())
TypeError: can't concat str to bytearray

(happens with Ctrl-q + something in pdbpp prompt)

Taken out of #2.

Reverts pypy@a59f338cc7b6c.

Fixes:

  File "/usr/lib/python3.7/cmd.py", line 126, in cmdloop
    line = input(self.prompt)
  File "…/src/pyrepl/pyrepl/readline.py", line 229, in raw_input
    ret = reader.readline(startup_hook=self.startup_hook)
  File "…/src/pyrepl/pyrepl/reader.py", line 605, in readline
    self.handle1()
  File "…/src/pyrepl/pyrepl/reader.py", line 588, in handle1
    self.do_cmd(cmd)
  File "…/src/pyrepl/pyrepl/reader.py", line 535, in do_cmd
    cmd.do()
  File "…/src/pyrepl/pyrepl/commands.py", line 373, in do
    r.insert((self.event + r.console.getpending().data) * r.get_arg())
TypeError: can't concat str to bytearray
@blueyed
Copy link
Collaborator Author

blueyed commented Aug 15, 2019

@antocuni
Travis is not running anymore.

@blueyed blueyed closed this Aug 15, 2019
@blueyed blueyed reopened this Aug 15, 2019
@blueyed blueyed closed this Aug 15, 2019
@blueyed blueyed reopened this Aug 15, 2019
@blueyed
Copy link
Collaborator Author

blueyed commented Aug 15, 2019

Enabled it now (after access was granted to my request), but https://travis-ci.org/pypy/pyrepl/requests says:

Build type disabled via repository settings (pull_request).

@blueyed
Copy link
Collaborator Author

blueyed commented Aug 15, 2019

@antocuni
It needs to be enabled on https://github.com/organizations/pypy/settings/installations likely.

If this is not fixed until tomorrow I'll consider moving it back to the pdbpp org.

@blueyed blueyed closed this Aug 15, 2019
@blueyed blueyed reopened this Aug 15, 2019
@mattip mattip closed this Aug 15, 2019
@mattip mattip reopened this Aug 15, 2019
@codecov-io
Copy link

codecov-io commented Aug 15, 2019

Codecov Report

Merging #17 into master will increase coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   61.11%   61.42%   +0.31%     
==========================================
  Files          22       22              
  Lines        2232     2237       +5     
  Branches      325      325              
==========================================
+ Hits         1364     1374      +10     
+ Misses        754      749       -5     
  Partials      114      114
Impacted Files Coverage Δ
testing/test_wishes.py 100% <ø> (ø) ⬆️
testing/infrastructure.py 95% <100%> (+0.26%) ⬆️
pyrepl/commands.py 58.9% <100%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b4b78...9a24f25. Read the comment docs.

@blueyed blueyed merged commit b3138ab into pypy:master Aug 15, 2019
@blueyed blueyed deleted the fix-qIHelp branch August 15, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants