-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/re-enable quoted_insert: use self.evt.data #17
Conversation
Reverts pypy@a59f338cc7b6c. Fixes: File "/usr/lib/python3.7/cmd.py", line 126, in cmdloop line = input(self.prompt) File "…/src/pyrepl/pyrepl/readline.py", line 229, in raw_input ret = reader.readline(startup_hook=self.startup_hook) File "…/src/pyrepl/pyrepl/reader.py", line 605, in readline self.handle1() File "…/src/pyrepl/pyrepl/reader.py", line 588, in handle1 self.do_cmd(cmd) File "…/src/pyrepl/pyrepl/reader.py", line 535, in do_cmd cmd.do() File "…/src/pyrepl/pyrepl/commands.py", line 373, in do r.insert((self.event + r.console.getpending().data) * r.get_arg()) TypeError: can't concat str to bytearray
@antocuni |
Enabled it now (after access was granted to my request), but https://travis-ci.org/pypy/pyrepl/requests says:
|
@antocuni If this is not fixed until tomorrow I'll consider moving it back to the pdbpp org. |
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 61.11% 61.42% +0.31%
==========================================
Files 22 22
Lines 2232 2237 +5
Branches 325 325
==========================================
+ Hits 1364 1374 +10
+ Misses 754 749 -5
Partials 114 114
Continue to review full report at Codecov.
|
Reverts a59f338cc7b6c.
Fixes:
(happens with
Ctrl-q
+ something in pdbpp prompt)Taken out of #2.