Update pyrevitlib\pyrevit\revit\selection.py

[Denver-22]

Fixed a bug where the revit.pick_linked() and revit.pick_linkeds() methods returned None due to incorrectly retrieving link instance elements.

The remaining "pick_" and "get_picked_" methods were unaffected.

[devloai]

PR Summary:

This PR fixes a bug where pick_linked() and pick_linkeds() methods returned None by adding logic to retrieve linked elements from RevitLinkInstance documents. The fix adds a conditional check to handle linked elements differently from regular elements, retrieving them from the linked document using GetLinkDocument() and LinkedElementId.

Review Summary:

The fix addresses the core issue but has critical gaps: it lacks an obj_type check (affecting pick_face()/pick_edge() behavior), missing null validation for unloaded links (causing crashes per Revit API defensive patterns in knowledge base), and redundant API calls (3x per reference). The suggested refactor uses an explicit loop with proper validation to handle linked elements safely while maintaining performance.

Follow-up suggestions:

• @devloai fix the identified issues
• @devloai add test cases for unloaded link scenarios

[Denver-22]

Is devloai's code fix proposal automatically included in the PR or do I have to do it myself?

[jmcouffin]

It is not. Like the copilot review when in launch them.
Always review and test. I let people do a first pass at ai reviews before reviewing myself

[Denver-22]

I tested the code suggested by ai. It works.

[Copilot]

Pull request overview

This PR fixes a bug in the pick_linked() and pick_linkeds() methods where they were incorrectly attempting to retrieve linked elements using GetGeometryObjectFromReference() instead of properly accessing the linked document and element.

Key Changes:

• Fixed linked element retrieval by checking if the picked object is a RevitLinkInstance and using GetLinkDocument() and LinkedElementId to access the actual element in the linked document
• Refactored the geometry object retrieval logic from a list comprehension to an explicit loop to accommodate the conditional handling

[github-actions]

📦 New work-in-progress (wip) builds are available for 5.3.1.25326+1040-wip

[github-actions]

📦 New work-in-progress (wip) builds are available for 5.3.1.25326+2050-wip