Update docs to make Predictive behavior more clear #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
fehiepsi
reviewed
Aug 26, 2024
numpyro/infer/util.py
Outdated
|
|
||
| import jax | ||
| import jax.numpy as jnp | ||
| import numpy as np |
There was a problem hiding this comment.
Could you revert the order of those imports? This seems to make CI failing.
|
@tomwallis We are going to make a new patch release soon. Do you want to incorporate this change in the release? |
|
Sorry @fehiepsi I was on holiday then too busy. Hopefully this fixes the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue, improving the docs for how the
Predictiveclass is expected to function. In particular, I try to make it more clear that the observations should be set toNoneto explicitly make prior or posterior predictions.I updated the docstring for the class itself, and also two of the example
ipynbs.In the docstring files there are also some
blackimport re-orderings.