Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating svi tutorial 1 with cells instead of inline #2723

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Padarn
Copy link

@Padarn Padarn commented Dec 25, 2020

Addresses #2714

See new version versus old version.

@fritzo
Copy link
Member

fritzo commented Jan 4, 2021

@Padarn I'm undecided whether this improves readability. On the one hand users can now execute code cells everywhere in the notebook, not just at the end. On the other hand that executability requires extra machinery , and that extra machinery slightly steals attention from the salient parts of pyro being explained.

@ab-10 can you explain a bit more about how you'd like to execute the code in the tutorial, and how the final executable code block isn't accomplishing that?

@eb8680 do you have any opinion?

@Padarn
Copy link
Author

Padarn commented Jan 5, 2021

Hi, @fritzo thanks for taking a look. I'm actually in agreement with you that this doesn't really improve readability. Possibly it would make sense to remove the final 'all in one' block', if the cells are executable.

@fritzo fritzo added WIP and removed awaiting review labels Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants