Allow returning deterministic sites from guide in Predictive #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlaRonning
commented
Apr 22, 2024
| @@ -284,7 +290,7 @@ def check_model_guide_match(model_trace, guide_trace, max_plate_nesting=math.inf | |||
| warnings.warn( | |||
| "Found auxiliary vars in the model: {}".format(aux_vars & model_vars) | |||
| ) | |||
| if not (guide_vars <= model_vars | aux_vars): | |||
| if not (guide_vars <= model_vars | aux_vars | det_vars): | |||
There was a problem hiding this comment.
@fritzo, it looks like deterministic sites are currently treated as (auxiliary) sample sites in the guide when comparing the model to the guide. Do you know if this is the intended behavior? I assumed it wasn't and sketched the following solution.
There was a problem hiding this comment.
Hi @OlaRonning, I'm unsure as I seldom use predictive, preferring custom predictive utilities.
@fehiepsi do you have an opinion? It would be nice to keep similar behavior in pyro and numpyro.
…uide-return Features/test deterministic guide return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3358.