Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New github action to build and upload the ide extension. #25

Closed

Conversation

karolh2000
Copy link
Member

@karolh2000 karolh2000 commented Jan 30, 2023

Description

New github action to build and upload the ide extension.

Screenshots (optional)

PR Checklist

Code Contributions

@karolh2000 karolh2000 requested a review from a team as a code owner January 30, 2023 22:36
@karolh2000 karolh2000 self-assigned this Jan 30, 2023
@karolh2000 karolh2000 requested review from efrisch and removed request for a team January 30, 2023 22:36
@karolh2000 karolh2000 marked this pull request as draft January 30, 2023 22:37
@karolh2000 karolh2000 changed the title - Workflow to build and upload the ide extension binaries New github action to build and upload the ide extension. Jan 30, 2023
@karolh2000 karolh2000 force-pushed the karolh2000/new_workflow_for_binaries branch from 4d0c0f9 to 7dffccb Compare January 31, 2023 01:06
@karolh2000 karolh2000 mentioned this pull request Jan 31, 2023
@karolh2000
Copy link
Member Author

#11

Copy link

@sbtaylor15 sbtaylor15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karolh2000
Copy link
Member Author

karolh2000 commented Feb 1, 2023

/lgtm

Hi @sbtaylor15 , I was hoping that maybe you can suggest a solution on how to upload the binaries to https://vscode.pyrsia.io/ or point me to a GitHub action that does something similar. Thanks!

@sbtaylor15
Copy link

@karolh2000 Here are the GH steps for the upload. You will need to create a new script modeled from the chartmuseum.sh to get the new installer into the right location in the directories and sync it. Also, add genlisting.py to your repo. genlisting.py is used to create a web page that allows you to navigate the repo from a browser.

      # Login to GCS
      - name: Google Auth
        if: github.repository_owner == 'pyrsia' && (github.event_name == 'push' || github.event_name == 'release')
        uses: 'google-github-actions/auth@v1'
        with:
          workload_identity_provider: 'projects/679352079717/locations/global/workloadIdentityPools/pyrsia-pool/providers/github-provider'
          service_account: '[email protected]'

      # Add gsutils
      - name: Set up Cloud SDK
        if: github.repository_owner == 'pyrsia' && (github.event_name == 'push' || github.event_name == 'release')
        uses: 'google-github-actions/setup-gcloud@v1'

      # Add the updated helm chart to the helm NIGHTLY repo
      - name: Add the updated helm chart to the helm NIGHTLY repo
        if: github.repository_owner == 'pyrsia' && (github.event_name == 'push' || github.event_name == 'release')
        run: |
          .github/workflows/chartmuseum.sh nightly

      # Add the updated helm chart to the helm STABLE repo
      - name: Add the updated helm chart to the helm STABLE repo
        if: github.repository_owner == 'pyrsia' && github.event_name == 'release'
        run: |
          .github/workflows/chartmuseum.sh stable

@karolh2000
Copy link
Member Author

@sbtaylor15 I see the following code in chartmuseum.sh

gsutil -m rsync -r gs://helmrepo/repos repos

For the vs code extension binaries, should we replace this line with a different gs: ? I'm guessing we don't want to store the vs code extension binaries in the pyrsia helm repo?

…the GC bucket

- python script to generate the list of binary files
@karolh2000
Copy link
Member Author

Heads up, this PR will be used to tests the GC scripts so I might need a few iteration to get it right.

@dasmanas
Copy link
Contributor

dasmanas commented Feb 6, 2023

@karolh2000 let me know if you need any help. I also made some improvement on the sync process to avoid downloading the whole set of files from Cloud Bucket to GitHub runner through pyrsia/pyrsia#1580.

@karolh2000
Copy link
Member Author

pyrsia/pyrsia#1580

@dasmanas Let's chat soon, I'll ping you later today, I think you might be able to help me with the GC auth error (GC auth is failing in the PR). Thanks!

@karolh2000
Copy link
Member Author

This PR was moved to #28 because of the github token issues for forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants