Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RC 0.3.5 #120

Merged
merged 43 commits into from
Jul 16, 2024
Merged

RC 0.3.5 #120

merged 43 commits into from
Jul 16, 2024

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented May 1, 2024 •
edited
Loading

Description

RC for v0.3.5

Checklist:

  • Update the version number
  • Verify and update Zenodo information in .zenodo.json
  • doc tests pass locally
  • activate this branch on readthedocs (include link here)
  • Upload the test distribution to the testPyPi server
  • Contacted developers and users about the future release
  • Performed integration tests with downstream packages (include list of these packages)
  • Create a wiki page with the release text (put link here)
  • After approval, confirm all changes from the RC pull are listed in the wiki release text.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

jklenzing and others added 27 commits June 22, 2023 15:44
@jklenzing
Merge pull request #114 from pysat/main
0ba6e78 
Update develop with v0.3.4
@jklenzing
MAINT: update workflows
cb9d437
@jklenzing
DOC: update changelog
a022579
@jklenzing
MAINT: add sphinx rtd theme cap
061060a
@jklenzing
MAINT: use pip install
a44d48c
@jklenzing
Merge pull request #115 from pysat/maint/workflows
d9dfc65 
MAINT: update GA workflows
@aburrell
DOC: add funding acknowledgements
465530e 
Added funding acknowledgements to the repository and documentation.
@aburrell
DOC: updated changelog
f6bd0f1 
Added a summary of changes to the changelog.
@aburrell
DOC: updated init header
e2ec49e 
Updated the main repository init header.
@aburrell
DOC: updated instrument headers
d662526 
Updated the instrument headers with the NRL pub release.
@aburrell
DOC: updated instrument method headers
1a50fee 
Updated the Instrument methods headers with the NRL pub release statement.
@aburrell
DOC: updated methods headers
4f83ad8 
Updated the methods headers with the NRL pub release statement and improved the docstrings.
@aburrell
DOC: updated test headers
c1129f3 
Updated the headers for the unit test files, improved the docstrings, and updated some comments.
@aburrell
DOC: updated utils headers
3564a62 
Updated the utils headers to include the NRL pub release.
@aburrell
STY: updated docstrings and line length
fa06de5 
Updated the docstrings to remove formatting characters and fixed lines that were too long for PEP8.
@aburrell
STY: fix formatting
aa7b5b8 
Remove extra lines and capitalize planet's name.
@aburrell
DOC: improved instructions
49017f5 
Improved spacing in the documentation, line length in the readme, and added a
link to the full package documentation in the documentation section of the
readme.
@aburrell
MAINT: removed extra figure
973063f 
Removed the extra "poweredbypysat" figure from the main directory.
@aburrell
STY: removed trailing whitespace
2db485a 
Removed trailing whitespace from the docstring.
@aburrell
MAINT: added .readthedocs.yml
7e31ff2 
Added a yaml for ReadTheDocs.
@aburrell
Merge pull request #118 from pysat/nrl_pub_release
647def0 
NRL pub release
@jklenzing
MAINT: update workflow versions
c9e89c5
@jklenzing
DOC: update changelog
1f28ba5
@jklenzing
DOC: update pyproject.toml
8962042
@jklenzing
BUG: pip install
1d97e3e
@jklenzing
Merge pull request #119 from pysat/maint/nep29_apr24
a658f54
@jklenzing
DOC: tentative release date
7070735
@jklenzing jklenzing marked this pull request as ready for review May 2, 2024 15:42
@jklenzing jklenzing requested review from rstoneback and aburrell May 2, 2024 15:43
@jklenzing jklenzing requested a review from JonathonMSmith May 2, 2024 15:43
@aburrell aburrell added this to the 0.3.5 Release milestone May 2, 2024
rstoneback
rstoneback reviewed Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@rstoneback rstoneback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Sorry for the delay. Saw this review request in my messages today.

One request, can my institution in the zenodo document be updated to Cosmic Studio ?

@jklenzing
Copy link
Member Author

Looks good! Sorry for the delay. Saw this review request in my messages today.

One request, can my institution in the zenodo document be updated to Cosmic Studio ?

Thanks for catching that. Fixed it.

jklenzing
jklenzing commented Jul 12, 2024
View reviewed changes
@jklenzing
Copy link
Member Author

@aburrell, I was updating the date to finish this off and found a new apexpy related bug:

E           NameError: name 'fa' is not defined

@aburrell
Copy link
Member

Looks like that could be related to the release of numpy 2.0.0 😿. It'll probably (?) be fixed if you limit the numpy version to 1.X.

On a more positive note, I think if you specify the compilers, you can get apexpy installed on the MacOS tests.

aburrell added 13 commits July 12, 2024 18:07
@aburrell
TST: apexpy installation
5d0088b 
Try to fix apexpy installation.
@aburrell
BUG: remove tabs
8933bab 
Remove tabs from yaml.
@aburrell
BUG: fix apexpy errors
86adf7d 
Fix errors in apexpy installation attempt.
@aburrell
BUG: uninstall numpy
95da359 
Added an uninstall line for numpy to fix downgrade.  Also fixed the gcc calls.
@aburrell
BUG: replaced tab
c3cda2c 
Replaced tab with spaces.
@aburrell
BUG: find gcc
a2e0c3e 
Added lines to find gcc and a potential fix for uninstalling numpy.
@aburrell
BUG: fix numpy install
cedaa1b 
Fix the limited numpy install to use a good max version number and changed the gcc debug statements.
@aburrell
BUG: remove numpy fix
d4c3b68 
Remove the numpy fix attempt
@aburrell
BUG: remove tab
45e6014 
Removed tab from yaml.
@aburrell
BUG: toggle apexpy to NEP29
5fbd019 
Only test apexpy with oldest numpy.
@aburrell
BUG: numpy is being upgraded
ad1bcc2 
The 'only-if-needed' is upgrading numpy to latest.
@aburrell
BUG: change numpy install order
de8f8a9 
Try changing the numpy install order.
@aburrell
BUG: downgrade scipy
d3c88ea 
Downgrade scipy for NEP29.
@aburrell
Copy link
Member

Ok, I fixed the MacOS installation, but couldn't get GA to downgrade numpy for the apexpy install. So, I toggled current testing to NEP29 only. This lead to the uncovering of a bug, where you were never testing NEP29. So I also fixed NEP29.

The apexpy numpy 2.0.0 issues are documented, and it can run with numpy 2.0.0 if you install with a lower version of numpy. So we'll work on that for a new release.

jklenzing
jklenzing commented Jul 16, 2024
View reviewed changes
@jklenzing jklenzing merged commit 7eae852 into main Jul 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstoneback rstoneback rstoneback approved these changes

@aburrell aburrell aburrell approved these changes

@JonathonMSmith JonathonMSmith Awaiting requested review from JonathonMSmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.5 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@jklenzing @aburrell @rstoneback