Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let PySide build with MinGW
WIN32 _WINDOWS compile definitions are defined for MinGW
" " are added to shiboken command generator parameters for all lines which contains ${PATH_SEP}
For example:
--include-paths=${pyside_SOURCE_DIR}${PATH_SEP}${QT_INCLUDE_DIR}
When PATH_SEP is ';' the line becomes
--include-paths=${pyside_SOURCE_DIR};${QT_INCLUDE_DIR}
which for cmake is
--include-paths=${pyside_SOURCE_DIR} ${QT_INCLUDE_DIR}
And Shiboken fails to run
Signed-off-by: Viacheslav Yartsev [email protected]