Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let PySide build with MinGW #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asergunov
Copy link

Let PySide build with MinGW

WIN32 _WINDOWS compile definitions are defined for MinGW

" " are added to shiboken command generator parameters for all lines which contains ${PATH_SEP}

For example:
--include-paths=${pyside_SOURCE_DIR}${PATH_SEP}${QT_INCLUDE_DIR}
When PATH_SEP is ';' the line becomes
--include-paths=${pyside_SOURCE_DIR};${QT_INCLUDE_DIR}
which for cmake is
--include-paths=${pyside_SOURCE_DIR} ${QT_INCLUDE_DIR}

And Shiboken fails to run

Signed-off-by: Viacheslav Yartsev [email protected]

Signed-off-by: Viacheslav Yartsev <[email protected]>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants