Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix Downloading on iSH #1473

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Fix Downloading on iSH #1473

wants to merge 3 commits into from

Conversation

Lockl00p
Copy link
Contributor

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

It’s a simple fix, everything should work

Checklist

  • any anime playing
  • bumped version
  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)
  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@Lockl00p Lockl00p requested a review from Derisis13 as a code owner January 15, 2025 18:06
@Lockl00p Lockl00p changed the title Fix Downloading on iSH fix: Fix Downloading on iSH Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Derisis13 Derisis13 Awaiting requested review from Derisis13 Derisis13 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Lockl00p