Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] consider testpaths config when looking for manage.py #478

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented May 15, 2017

I've came up with this when using pytest-django with https://github.com/djangonauts/django-rest-framework-gis/ (openwisp/django-rest-framework-gis#123), where it turned out useful to detect and add the tests dir to sys.path - but it's probably not a good idea altogether?! (for the common case)

TODO:

  • doc
  • tests
  • Q: should it only consider testpaths (and not args) if it is configured?

@blueyed blueyed requested a review from pelme May 15, 2017 14:07
@codecov-io
Copy link

codecov-io commented Oct 10, 2017

Codecov Report

Merging #478 into master will decrease coverage by 6.88%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
- Coverage   92.63%   85.74%   -6.89%     
==========================================
  Files          32       32              
  Lines        1793     1614     -179     
  Branches      153      140      -13     
==========================================
- Hits         1661     1384     -277     
- Misses         94      177      +83     
- Partials       38       53      +15
Flag Coverage Δ
#dj110 ?
#dj111 ?
#dj18 ?
#dj19 ?
#dj20 ?
#dj21 ?
#django110 81.72% <66.66%> (?)
#django111 83.45% <66.66%> (?)
#django17 79.61% <66.66%> (?)
#django18 80.79% <66.66%> (?)
#django19 79.86% <66.66%> (?)
#mysql_innodb 78.99% <66.66%> (-6.17%) ⬇️
#mysql_myisam 78.93% <66.66%> (-6.07%) ⬇️
#postgres 81.22% <66.66%> (-7.18%) ⬇️
#py27 83.02% <66.66%> (-7.11%) ⬇️
#py34 80.91% <66.66%> (-3.75%) ⬇️
#py35 79.12% <66.66%> (-5.77%) ⬇️
#py36 80.91% <66.66%> (-4.81%) ⬇️
#py37 ?
#pypy 81.59% <66.66%> (?)
#pypy3 80.79% <66.66%> (?)
#pytest3 85.74% <66.66%> (?)
#sqlite 81.59% <66.66%> (-5.3%) ⬇️
#sqlite_file 80.29% <66.66%> (-4.37%) ⬇️
Impacted Files Coverage Δ
pytest_django/plugin.py 67.37% <66.66%> (-18.91%) ⬇️
pytest_django/migrations.py 0% <0%> (-100%) ⬇️
pytest_django/fixtures.py 83.54% <0%> (-13.68%) ⬇️
pytest_django/live_server_helper.py 80.95% <0%> (-11.24%) ⬇️
tests/test_database.py 98.91% <0%> (-0.26%) ⬇️
tests/conftest.py 100% <0%> (ø) ⬆️
tests/test_environment.py 100% <0%> (ø) ⬆️
tests/test_db_setup.py 100% <0%> (ø) ⬆️
tests/test_django_settings_module.py 100% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d61618...f70cb89. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants