Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Prefix all fixtures with "django_" #711

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Mar 15, 2019

TODO:

  • doc

As for deprecation warnings, I think this is not really needed (now), but asked about it in pytest-dev/pytest#4900 (comment) already.

@codecov-io
Copy link

Codecov Report

Merging #711 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   98.03%   98.04%   +<.01%     
==========================================
  Files          32       32              
  Lines        1831     1839       +8     
  Branches      142      142              
==========================================
+ Hits         1795     1803       +8     
  Misses         23       23              
  Partials       13       13
Flag Coverage Δ
#dj110 85.64% <100%> (+0.06%) ⬆️
#dj111 87.92% <100%> (+0.05%) ⬆️
#dj18 86.62% <100%> (+0.05%) ⬆️
#dj19 85.69% <100%> (+0.06%) ⬆️
#dj20 87.87% <100%> (+0.05%) ⬆️
#dj21 85.37% <100%> (+0.06%) ⬆️
#dj22 83.25% <100%> (+0.07%) ⬆️
#djmaster 81.23% <100%> (+0.08%) ⬆️
#mysql_innodb 86.13% <100%> (+0.06%) ⬆️
#mysql_myisam 85.97% <100%> (+0.06%) ⬆️
#postgres 91.13% <100%> (+0.03%) ⬆️
#py27 90.97% <100%> (+0.03%) ⬆️
#py34 85.69% <100%> (+0.06%) ⬆️
#py35 85.64% <100%> (+0.06%) ⬆️
#py36 88.79% <100%> (+0.04%) ⬆️
#py37 85.75% <100%> (+0.06%) ⬆️
#pytest41 85.1% <100%> (+0.06%) ⬆️
#sqlite 90.37% <100%> (+0.04%) ⬆️
#sqlite_file 85.69% <100%> (+0.06%) ⬆️
#xdist 87.87% <100%> (+0.05%) ⬆️
Impacted Files Coverage Δ
pytest_django/fixtures.py 97.31% <ø> (ø) ⬆️
pytest_django/plugin.py 93.88% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55c709...606617b. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Mar 15, 2019

Codecov Report

Merging #711 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
- Coverage      98%   97.91%   -0.09%     
==========================================
  Files          32       32              
  Lines        1853     1873      +20     
  Branches      147      147              
==========================================
+ Hits         1816     1834      +18     
- Misses         24       26       +2     
  Partials       13       13
Flag Coverage Δ
#dj110 85.79% <100%> (+0.04%) ⬆️
#dj111 88.04% <100%> (+0.02%) ⬆️
#dj18 86.75% <100%> (+0.03%) ⬆️
#dj19 85.79% <100%> (+0.04%) ⬆️
#dj20 87.98% <100%> (+0.02%) ⬆️
#dj21 85.53% <100%> (+0.04%) ⬆️
#dj22 83.44% <100%> (+0.07%) ⬆️
#djmaster 81.47% <100%> (+0.09%) ⬆️
#mysql_innodb 86.27% <100%> (+0.04%) ⬆️
#mysql_myisam 86.11% <100%> (+0.04%) ⬆️
#postgres 91.19% <100%> (-0.02%) ⬇️
#py27 91.03% <100%> (-0.02%) ⬇️
#py34 85.79% <100%> (+0.04%) ⬆️
#py35 85.79% <100%> (+0.04%) ⬆️
#py36 88.89% <100%> (+0.01%) ⬆️
#py37 85.9% <100%> (+0.04%) ⬆️
#pytest41 85.26% <100%> (+0.05%) ⬆️
#sqlite 90.38% <100%> (-0.01%) ⬇️
#sqlite_file 85.79% <100%> (+0.04%) ⬆️
#xdist 87.98% <100%> (+0.02%) ⬆️
Impacted Files Coverage Δ
pytest_django/fixtures.py 96.29% <100%> (-1.02%) ⬇️
pytest_django/plugin.py 94.27% <100%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a79fba...33ce083. Read the comment docs.

live_server = django_live_server
rf = django_rf
settings = django_settings
transactional_db = django_transactional_db
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is problematic for x in request.funcargnames checks being used.. :/

@blueyed
Copy link
Contributor Author

blueyed commented Mar 16, 2019

Updated docs, and started to use new fixtures only internally, but it is quite messy.

What also should be considered is using prefixes with the option names..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants