Fix hang with --dist=loadgroup if a crashed worker is replaced#1324
Open
radoering wants to merge 1 commit intopytest-dev:masterfrom
Open
Fix hang with --dist=loadgroup if a crashed worker is replaced#1324radoering wants to merge 1 commit intopytest-dev:masterfrom
--dist=loadgroup if a crashed worker is replaced#1324radoering wants to merge 1 commit intopytest-dev:masterfrom
Conversation
radoering
force-pushed
the
fix-loadgroup-hang
branch
from
6c94249 to
25282ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1323
In addition to the fix in
remove_node(), I added a sanity check in_assign_work_unit(). (Without the fix and the sanity check the unit test hangs. Without the fix but with the sanity check, it fails due to theRuntimeError.)