Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug approx on dict when the order is not the same #12445

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix bug approx on dict when the order is not the same #12445

wants to merge 3 commits into from

Conversation

yechielvi
Copy link

Closes #12444

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Jun 29, 2024
Tusenka
Tusenka reviewed Dec 8, 2024
View reviewed changes
Copy link

@Tusenka Tusenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests for the fix

src/_pytest/python_api.py
for (approx_key, approx_value), other_value in zip(
approx_side_as_map.items(), other_side.values()
):
for approx_key, approx_value in approx_side_as_map.items():
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this fixes the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tusenka Tusenka Tusenka approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bot:chronographer:provided (automation) changelog entry is part of PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pytest approx wrong formatting return - printing all values as wrong.
2 participants
@yechielvi @Tusenka