Prevent parametrize with scope from breaking fixture dependencies #13249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
RonnyPfannschmidt
approved these changes
Feb 25, 2025
| # fixture. Scope control is enforced for parametrized fixtures | ||
| # by recreating the whole fixture tree on parameter change. | ||
| # Hence `fixturedef._scope`, not `scope`. | ||
| self._check_scope(fixturedef, fixturedef._scope) | ||
| subrequest = SubRequest( |
There was a problem hiding this comment.
I think need to validate what we do with subrequest there
The feature is slightly inconsistent and confused me
But I believe that's fine to do as a followup
I want to dig at history a bit before merge tho
nicoddemus
approved these changes
Mar 1, 2025
There was a problem hiding this comment.
LGTM, thanks @Anton3!
Leaving merging to @RonnyPfannschmidt as requested. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13248