separate subtests failures to give better indication on tests analysis #13987
+28
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the double-counting of subtest failures in pytest's final test summary. Previously, when a test with subtests had failures, both the subtest failure and the top-level test failure were counted as regular "failed" tests, leading to inflated failure counts.
Changes
pytest_report_teststatushook insrc/_pytest/subtests.pyto return"subtests failed"category instead of"failed"for subtest failures_determine_main_colorinsrc/_pytest/terminal.pyto consider"subtests failed"when determining the main color (red)parse_summary_nounsinsrc/_pytest/pytester.py:testing/test_subtests.pyto match the new summary formatExample
Before:
===================== 2 failed, 2 subtests passed in 0.02s =====================After:
===================== 1 failed, 2 subtests passed, 1 subtests failed in 0.02s =====================This provides clear visibility into:
Closes #13986