-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(entropy): Limit number of hashes #1822
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
} | ||
|
||
|
||
pub async fn update_commitments_if_necessary( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: I think the verb "update" is a bit confusing here because it suggests that the caller could set the commitment to anything they want. A better name would be "advance", which implies that you can only move forward in the same hash chain.
@@ -38,6 +38,11 @@ interface EntropyEvents { | |||
address oldFeeManager, | |||
address newFeeManager | |||
); | |||
event ProviderMaxNumHashesUpdated( | |||
address provider, | |||
uint64 oldMaxNumHashes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small detail, but is there a reason that this is a uint64
when the struct field is only a uint32
?
No description provided.