fix(target_chains/near): update dependencies and code to make tests work#2100
Merged
ali-behjati merged 8 commits intomainfrom Nov 7, 2024
Merged
fix(target_chains/near): update dependencies and code to make tests work#2100ali-behjati merged 8 commits intomainfrom
ali-behjati merged 8 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Riateche
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old
workspacespackage in near that is used as a test suite couldn't download the requirednear-sandboxfor it from an external url and it resulted in integration tests failing.The new workspaces package is called
near-workspacesand itsnear-sandboxhas some rust version requirements to fully work, otherwise it panics withCompilationError(PrepareError(Deserialization)). The rust version 1.79.0 that its sandbox uses works but the latest stable rust 1.82.0 still fails. This assumption is not documented anywhere and I guessed it based on this old issue.In the journey to make it work with @Riateche, we ended up updating the SDKs hoping to fix the problem and it's probably not needed but as the changes are good and will save us time in the future, i'll be keeping them.