Bduran/dual publish #3160
Bduran/dual publish #3160
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
6 Skipped Deployments
|
There was a problem hiding this comment.
dumb question, what is this?
There was a problem hiding this comment.
this is a file that tells typescript that there are typings for this plain javascript file, even if it doesn't have one. this was required to allow typescript to build this project without erroring, after moving to a more strict typescript config (this is specifically for this file: target_chains/ethereum/contracts/scripts/contractManagerConfig.js)
There was a problem hiding this comment.
i'm wondering why we have similar git ignore files everywhere, i think it might be good to move some just up at the root of the repo
There was a problem hiding this comment.
good callout. could probably just apply a blanket ignore and allow local packages to override as needed.
I can address in a separate PR, so as to not bloat this already excessively-large one 🫠
|
LGTM |
Summary
betanpm tag, where I have been updating it.tsconfig.jsonfiles that drifted from the repo best practices.ts-duality, generatedtsconfig.build.jsonfiles, which are exclusively used for building packages.Rationale
we have many brilliant engineers here, but only a few who have been deep in the TypeScript and JavaScript weeds, especially with regards to package build and distribution practices. This PR is an initial step to clamp on a single "paved-path" way of doing things here.
How has this been tested?
package.json#exportsrelatedTested building and running the following apps (which are powered by NextJS). Will check more off as more tests and changes are made. Anything with a
strikethroughis unrelated and likely not a JS / TS project. Verification involved verifying the apps loaded up without issue. Functionality-wise, they haven't been extensively tested.[ ] argus[ ] fortuna[ ] hermes[ ] hip-3-pusher[ ] pyth-lazer-agent[ ] quorumPicture of all builds passing locally