Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes #24

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Various fixes #24

wants to merge 5 commits into from

Conversation

eltos
Copy link
Contributor

@eltos eltos commented Mar 9, 2017

Replaced byte string concatenation with bytearray extend functions.
This is ~50 times faster!
(See also #8)

@eltos eltos mentioned this pull request Mar 9, 2017
Closed
@eltos eltos changed the title Major performance improvements Various fixes Nov 26, 2017
@eltos
Copy link
Contributor Author

eltos commented Nov 26, 2017

The additional commits include fixes for:

  • Exception when trying to close a lost connection, resulting in an unability to reconnect
  • Timeout parameter not used for creating the core client when opening a connection, causing the port mapper routine deep in the subsequent calls to block infinite under cerain circumstances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eltos