-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve hover results #452
base: develop
Are you sure you want to change the base?
Conversation
@tkrabel-db @HedgehogCode any way we can get this merged? looking forward to this change |
@PeterCardenas I'm afraid I have no rights to do so. |
ripped from python-lsp#452
- Use jedi Script.help instead of infer - Ensures that docstrings of the definition are used if possible instead of docstrings of the type - Show all possible signatures or types of the element hovered instead of just the first one that matches the name
Co-authored-by: tkrabel-db <[email protected]>
- Only show signatures for function and class types - Also show types if there are definitons without signatures next to definitions with signatures
f962c9e
to
738ee2f
Compare
Sorry for the late reply. The example above showed I also changed the code to show the type in cases where we have a signature but this is not the only option. Example:
On hover over "b":
|
This PR solves #444.
I tried to describe the changes pretty well in the comments in the code. Note that there are two
TODO(Review)
comments that I would like feedback on.Here are some examples of how the hover results change with this code change. The new results are highlighted with a green border.