Skip to content

feat: Add JWT leeway setting to KeycloakOAuth2 backend#1103

Merged
nijel merged 1 commit intopython-social-auth:masterfrom
mageo:feature/jwt-leeway-keycloak
May 26, 2025
Merged

feat: Add JWT leeway setting to KeycloakOAuth2 backend#1103
nijel merged 1 commit intopython-social-auth:masterfrom
mageo:feature/jwt-leeway-keycloak

Conversation

@mageo
Copy link
Copy Markdown

@mageo mageo commented Apr 9, 2025

Fixes #1102 by adding support for a JWT_LEEWAY setting in the Keycloak backend.

@nijel
Copy link
Copy Markdown
Member

nijel commented Apr 9, 2025

I'd really prefer to have a generic solution here instead of ad-hoc solutions per backend. See also #1031

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.69%. Comparing base (326d4b3) to head (c7ba3ad).
Report is 193 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1103      +/-   ##
==========================================
- Coverage   77.88%   77.69%   -0.20%     
==========================================
  Files         347      348       +1     
  Lines       10669    10636      -33     
  Branches      504      461      -43     
==========================================
- Hits         8310     8264      -46     
- Misses       2200     2212      +12     
- Partials      159      160       +1     
Flag Coverage Δ
unittests 77.69% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nijel nijel merged commit 2a99653 into python-social-auth:master May 26, 2025
11 of 12 checks passed
@nijel
Copy link
Copy Markdown
Member

nijel commented May 26, 2025

Let's merge this as it is as we are not using generic code path as in #1102.

@nijel nijel self-assigned this May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

ImmatureSignatureError The token is not yet valid

2 participants