Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: close TCP connection after CloseConnection event #150

Merged
merged 1 commit into from
Feb 3, 2021
Merged

server: close TCP connection after CloseConnection event #150

merged 1 commit into from
Feb 3, 2021

Conversation

belm0
Copy link
Member

@belm0 belm0 commented Feb 1, 2021

Fixes #115 and #147.

@belm0 belm0 requested a review from njsmith February 1, 2021 13:45
@belm0
Copy link
Member Author

belm0 commented Feb 1, 2021 •
edited

I have no idea what I'm doing-- but this change fixes the shutdown issue with asyncio client, and fixes all of the broken autobahn tests.

If this change is OK I should add a unit test. (done)

@njsmith does this one line change look harmful?

@coveralls
Copy link

coveralls commented Feb 1, 2021 •
edited

Pull Request Test Coverage Report for Build 163

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 95.761%
Totals Coverage Status
Change from base Build 155: 0.02%
Covered Lines: 497
Relevant Lines: 519
💛 - Coveralls

@belm0 belm0 force-pushed the fix_tcp_connection_close branch 2 times, most recently from cd2d2e8 to 3c30418 Compare February 2, 2021 12:45
@belm0 belm0 changed the title server: close TCP connection after closing websocket server: close TCP connection after CloseConnection event Feb 2, 2021
@belm0 belm0 merged commit 719c06a into master Feb 3, 2021
@belm0 belm0 deleted the fix_tcp_connection_close branch February 3, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njsmith njsmith Awaiting requested review from njsmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server does not automatically close TCP connection
2 participants
@belm0 @coveralls