Configure message buffer (#82) #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 103
💛 - Coveralls |
mehaase
force-pushed
the
configure_message_buffer
branch
from
f877c39
to
4520d2f
Compare
belm0
approved these changes
Nov 16, 2018
|
Umm, not sure how this got closed. Obviously I intended to merge it! |
|
Merged directly into master. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add arguments for configuring message queue size and maximum message size.
The closing code is needlessly complex and made the message size code very difficult to write, so I opened up #90 to refactor the way that closing is handled.
The only other thing that stands out to me is that the connection APIs have a lot of repeated arguments now. I know I could use
**kwargsto make this more DRY, but then I think (?) that the docs would show kwargs instead of the actual argument names, and that doesn't seem very user-friendly. Thoughts?