Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to prevent autodeps from running in forked repos #2892

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Try to prevent autodeps from running in forked repos #2892

merged 1 commit into from
Nov 30, 2023

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Nov 29, 2023

Refs #2885

@A5rocks A5rocks mentioned this pull request Nov 29, 2023
Open
17 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

Merging #2892 (7cadd1f) into master (592718b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2892   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files         115      115           
  Lines       17623    17623           
  Branches     3153     3153           
=======================================
  Hits        17543    17543           
  Misses         52       52           
  Partials       28       28

TeamSpen210
TeamSpen210 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@TeamSpen210 TeamSpen210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there isn't a better way to do this, though forks will default to not running actions at all. In that case you don't get tests of course.

richardsheridan
richardsheridan approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@richardsheridan richardsheridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will help old forks from before not running actions was the default too.

@A5rocks
Copy link
Contributor Author

A5rocks commented Nov 30, 2023

(well, as long as they merge in changes from upstream!)

@A5rocks A5rocks merged commit c8441a2 into python-trio:master Nov 30, 2023
29 checks passed
@A5rocks A5rocks deleted the exclusive-autodeps branch November 30, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardsheridan richardsheridan richardsheridan approved these changes

@TeamSpen210 TeamSpen210 TeamSpen210 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@A5rocks @richardsheridan @TeamSpen210