-
Notifications
You must be signed in to change notification settings - Fork 32
feat: use pypi_simple for PyPI simple API #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
85b3027 to
0fdb786
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A clarification question but overall looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I would prefer if @dhellmann or @LalatenduMohanty takes a look as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The project https://pypi.org/project/pypi-simple/ provides an easy-to-use, convenient wrapper around PyPI's simple HTML and JSON API as well as a bunch of packaging PEPs. Replace our custom `html5lib` and `requests` library with pypi-simple. PyPI API calls now prefer the faster, more feature-rich JSON API and fall back to HTML for local index and GitLab. Fixes: python-wheel-build#741 Signed-off-by: Christian Heimes <[email protected]>
The project https://pypi.org/project/pypi-simple/ provides an easy-to-use, convenient wrapper around PyPI's simple HTML and JSON API as well as a bunch of packaging PEPs. Replace our custom
html5libandrequestslibrary with pypi-simple.PyPI API calls now prefer the faster, more feature-rich JSON API and fall back to HTML for local index and GitLab.
Fixes: #741