gh-123853: Update locale.windows_locale #123901
Conversation
Update the table of Windows language code identifiers (LCIDs) to protocol version 16.0 (4/23/2024).
serhiy-storchaka
force-pushed
the
windows_locale-3
branch
from
7b80ad1
to
0b93c10
Compare
| @@ -0,0 +1,3 @@ | |||
| Update the table of Windows language code identifiers (LCIDs) used by | |||
| :func:`locale.getdefaultlocale()` on Windows to protocol version 16.0 | |||
| (4/23/2024). | |||
There was a problem hiding this comment.
| (4/23/2024). | |
| (2024-04-23). |
There was a problem hiding this comment.
This is how it is indicated in the original document.
There was a problem hiding this comment.
I understand but I dislike this date format, it's misleading. I prefer ISO 8601 date ;-)
| @@ -1467,10 +1467,15 @@ def getpreferredencoding(do_setlocale=True): | |||
| # | |||
|
|
|||
| windows_locale = { | |||
There was a problem hiding this comment.
Would it be possible to call GetLocaleInfo() instead of using a hardcoded dictionary?
There was a problem hiding this comment.
It is called. The dictionary is used if GetLocaleInfo fails to provide such information (on Windows 95, etc). That is, almost never.
And if we use GetLocaleInfo, windows_locale is not needed.
There is also better modern API than GetLocaleInfo, but since _getdefaultlocale() is deprecated anyway...
There was a problem hiding this comment.
It is called. The dictionary is used if GetLocaleInfo fails to provide such information (on Windows 95, etc)
We don't support Windows 95 anymore. Do you mean that the dict is no longer needed?
And if we use GetLocaleInfo, windows_locale is not needed.
I don't understand. getdefaultlocale() calls GetLocaleInfo() on Windows.
There was a problem hiding this comment.
Yes, I think that it is no longer needed. GetLocaleInfoA supports LOCALE_SISO639LANGNAME and LOCALE_SISO3166CTRYNAME on all modern Windows. It only returns a LCID if:
/* If we end up here, this windows version didn't know about
ISO639/ISO3166 names (it's probably Windows 95). Return the
Windows language identifier instead (a hexadecimal number) */And only in this case the dict is used.
| # http://msdn.microsoft.com/library/default.asp?url=/library/en-us/intl/nls_238z.asp | ||
| # to include every locale up to Windows Vista. | ||
| # https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-lcid/70feba9f-294e-491e-b6eb-56532684c37f | ||
| # to include every locale up to protocol revision 16.0 (4/23/2024). |
There was a problem hiding this comment.
| # to include every locale up to protocol revision 16.0 (4/23/2024). | |
| # to include every locale up to protocol revision 16.0 (2024-04-23). |
|
I only created this PR because you suggested to do this. This is actually a simplified version, it does not include names for reserved codes and ignores all parts of the name besides language and country. And it is completely useless. |
serhiy-storchaka
changed the title
Update the table of Windows language code identifiers (LCIDs) to protocol version 16.0 (4/23/2024).
locale.windows_locale: Incorrect Windows locale for Cambodian #123853