Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-123974: Fix OSError for thread_time clock on NetBSD by setting default resolution #123975

Merged
merged 3 commits into from
Sep 13, 2024
Merged

gh-123974: Fix OSError for thread_time clock on NetBSD by setting default resolution #123975

merged 3 commits into from
Sep 13, 2024

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Sep 11, 2024 •
edited by bedevere-app bot
Loading

@furkanonder furkanonder added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir 3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Sep 11, 2024
@bedevere-app bedevere-app bot mentioned this pull request Sep 11, 2024
Closed
@furkanonder furkanonder added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes and removed 3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Sep 13, 2024
vstinner
vstinner approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's unfortunate that clock_getres() doesn't work on NetBSD :-(

@vstinner vstinner merged commit b1d6f8a into python:main Sep 13, 2024
42 checks passed
@miss-islington-app
Copy link

Thanks @furkanonder for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2024
@furkanonder @miss-islington
pythongh-123974: Fix time.get_clock_info() on NetBSD (pythonGH-123975)
663809b 
Fix OSError for thread_time clock on NetBSD by setting default resolution.
(cherry picked from commit b1d6f8a)

Co-authored-by: Furkan Onder <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 13, 2024

GH-124072 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 13, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2024
@furkanonder @miss-islington
pythongh-123974: Fix time.get_clock_info() on NetBSD (pythonGH-123975)
3ce3798 
Fix OSError for thread_time clock on NetBSD by setting default resolution.
(cherry picked from commit b1d6f8a)

Co-authored-by: Furkan Onder <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 13, 2024

GH-124073 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 13, 2024
vstinner pushed a commit that referenced this pull request Sep 13, 2024
@miss-islington @furkanonder
[3.12] gh-123974: Fix time.get_clock_info() on NetBSD (GH-123975) (#1…
b2a7d71 
…24073)

gh-123974: Fix time.get_clock_info() on NetBSD (GH-123975)

Fix OSError for thread_time clock on NetBSD by setting default resolution.
(cherry picked from commit b1d6f8a)

Co-authored-by: Furkan Onder <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Sep 16, 2024
@serhiy-storchaka
Revert "pythongh-123974: Fix time.get_clock_info() on NetBSD (python#…
ed1a6c7 
…123975)"

This reverts commit b1d6f8a.
serhiy-storchaka added a commit that referenced this pull request Sep 18, 2024
@serhiy-storchaka
Revert "gh-123974: Fix time.get_clock_info() on NetBSD (#123975)" (GH…
79a7410 
…-124115)

This reverts commit b1d6f8a.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2024
@serhiy-storchaka @miss-islington
Revert "pythongh-123974: Fix time.get_clock_info() on NetBSD (pythonG…
8dd7695 
…H-123975)" (pythonGH-124115)

This reverts commit b1d6f8a.
(cherry picked from commit 79a7410)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Sep 18, 2024
@miss-islington @serhiy-storchaka
[3.12] Revert "gh-123974: Fix time.get_clock_info() on NetBSD (GH-123975
708173c 
)" (GH-124115) (GH-124200)

This reverts commit b1d6f8a.
(cherry picked from commit 79a7410)

Co-authored-by: Serhiy Storchaka <[email protected]>
@zware zware mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@furkanonder @vstinner