Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-85453: Improve class reference links on datetime.rst #123980

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

gh-85453: Improve class reference links on datetime.rst #123980

wants to merge 10 commits into from
+24 −24

Conversation

uatach
Copy link
Contributor

@uatach uatach commented Sep 11, 2024 •
edited by github-actions bot
Loading

Another pull request based on PR #21447, this one is focused on improving class reference links.

📚 Documentation preview 📚: https://cpython-previews--123980.org.readthedocs.build/

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 11, 2024
@bedevere-app bedevere-app bot mentioned this pull request Sep 11, 2024
Open
uatach
uatach commented Sep 11, 2024
View reviewed changes
Doc/library/datetime.rst Outdated Show resolved Hide resolved
erlend-aasland
erlend-aasland reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared the rendered preview with the existing docs, and there are still quite a few places where I think the link density is too high within a paragraph. I'll jot them down tomorrow or the day after.

Doc/library/datetime.rst Outdated Show resolved Hide resolved
Doc/library/datetime.rst Outdated Show resolved Hide resolved
Doc/library/datetime.rst Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

@picnixz picnixz picnixz left review comments

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uatach @picnixz @erlend-aasland