gh-116622: Kill Android Signal Catcher thread before running tests #123982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative attempt to fix the problem described in #123981, by killing the Android Signal Catcher completely. But it ended up being quite large and complex, and depends on several internal details which Android might change in the future.
Also, when I tried to test the "SignalCatcher TID %d still exists" message by commenting out the first
tgkill
call, I found that about 80% of the time, the 0.1 second delay between installing the signal handler and sending the signal somehow caused the handler to be bypassed, and the signal to kill the process. I have no idea why that would happen, and that makes me feel even less confident about this approach.As #123981 says, the original problem only occurs in a fairly rare combination of circumstances, has a clearly-identifiable log message, and some easy workarounds, so it isn't worth pursuing this.