gh-126209: Fix inconsistency of skip_file_prefixes in warnings.warn's C and Python implementations
#126329
+23
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
zsaladin
force-pushed
the
fix/warnings
branch
from
a2caf9a
to
3bd3350
Compare
picnixz
changed the title
skip_file_prefixes in warnings.warn's C and Python implementations
|
Some tips: could you avoid force-pushing your commits in the future please? It makes reviewing harder (see https://devguide.python.org/getting-started/pull-request-lifecycle). Thanks! |
picnixz
reviewed
Nov 2, 2024
Misc/NEWS.d/next/Core_and_Builtins/2024-11-02-18-01-31.gh-issue-126209.2ZIhrS.rst
Outdated
Show resolved
Hide resolved
…e-126209.2ZIhrS.rst Co-authored-by: Bénédikt Tran <[email protected]>
picnixz
reviewed
Nov 3, 2024
Co-authored-by: Bénédikt Tran <[email protected]>
My apology. I will avoid force-pushing as you said. |
Co-authored-by: Bénédikt Tran <[email protected]>
Eclips4
reviewed
Nov 3, 2024
Misc/NEWS.d/next/Core_and_Builtins/2024-11-02-18-01-31.gh-issue-126209.2ZIhrS.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Kirill Podoprigora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__file__. #126209I think setting the argument
end=-1the functiontailmatchmay cause undefined behavior. Most oftailmatchfunctions I've seen are used withend=PY_SSIZE_T_MAXand never seenend=-1except for this case.hopefully I will help