Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126313: Fix a crash in curse.napms due to incorrect error handling #126351

Merged
merged 3 commits into from
Nov 3, 2024
Merged

gh-126313: Fix a crash in curse.napms due to incorrect error handling #126351

merged 3 commits into from
Nov 3, 2024

Conversation

picnixz
Copy link
Contributor

@picnixz picnixz commented Nov 3, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 3, 2024
Closed
@picnixz picnixz requested a review from vstinner November 3, 2024 09:45
@picnixz
Copy link
Contributor Author

picnixz commented Nov 3, 2024 •
edited
Loading

The backports will need to be manual because they will be in conflict with the new structure of the curses module (I haven't changed much the macros so the backport will be easy).

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) November 3, 2024 13:47
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 3, 2024
@picnixz
Copy link
Contributor Author

picnixz commented Nov 3, 2024

(I think I forgot to include the latest CI tasks in this branch, which is why it was stuck)

@serhiy-storchaka serhiy-storchaka merged commit 19d9358 into python:main Nov 3, 2024
39 checks passed
@miss-islington-app
Copy link

Thanks @picnixz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @picnixz and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 19d935843727fff93b2c0e09a63fd32c0d97098d 3.13

@miss-islington-app
Copy link

Sorry, @picnixz and @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 19d935843727fff93b2c0e09a63fd32c0d97098d 3.12

@picnixz
Copy link
Contributor Author

picnixz commented Nov 3, 2024

I won't have time for the backports, so I'll do it upon my return (Wednesday). Anyone else is free to try.

@picnixz picnixz deleted the fix/curses-napms-126313 branch November 3, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rruuaanng rruuaanng rruuaanng left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

@serhiy-storchaka serhiy-storchaka

Labels
needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@picnixz @serhiy-storchaka @rruuaanng