gh-130428: Add tests for delattr suggestions #130455
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Lib/test/test_traceback.py
Outdated
| actual = self.get_suggestion(lambda: delattr(obj, 'somethingverywrong')) | ||
| self.assertNotIn("blech", actual) | ||
|
|
||
| def test_delattr_error_bad_suggestions_do_not_trigger_for_small_names(self): |
There was a problem hiding this comment.
This test is the same as for getattr, can't it be refactored so that we use the same fixtures but with different calls to self.get_suggestion?
There was a problem hiding this comment.
I was actually thinking of doing that, but decided to go with duplication for better readability.
On reconsideration with your review, I believe it is redundant and should be refactored. Will update the PR accordingly.
| if operation == "getattr": | ||
| actual = self.get_suggestion(obj, 'bluch') | ||
| elif operation == "delattr": | ||
| actual = self.get_suggestion(lambda: delattr(obj, 'bluch')) |
There was a problem hiding this comment.
I would also add an else branch saying that the operation is not recognized otherwise.
|
@Pranjal095 Some of the tests you added are failing, could you fix them please? |
|
Let's put it as a draft until #130427 is merged then. |
Depends on #130427.
With reference to the enhancement proposed in issue #130425, tests have been added to ensure proper functionality of delattr suggestions. To maintain consistency and readability of the code, they mirror the tests for getattr suggestions existing in the modified file (Lib/test/test_traceback.py).