-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-130396: Increase trashcan overhead #130552
base: main
Are you sure you want to change the base?
GH-130396: Increase trashcan overhead #130552
Conversation
markshannon
commented
Feb 25, 2025
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: Implement stack overflow protection for linux based on actual stack depth #130396
!buildbot Windows.*2022.*NoGIL |
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 1a1a46c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130552%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
!buildbot Windows.*2022.*NoGIL.*3 |
The regex 'Windows.*2022.*NoGIL.*3' did not match any buildbot builder. Is the requested builder in the list of stable builders? |
1a1a46c
to
ba9702c
Compare
So, to make sure I understand:
Can you clarify why these new numbers are chosen? It seems like it made sense before: deposit if we don't have room for a finalizer (margin of 1), and don't empty if doing so would immediately start putting stuff back in the trashcan (margin of 2, one higher than what's used in Are the new numbers chosen just because they're "higher"? If so, it's probably |
It is possible that the increase in Even so, I think it is a good idea to have a bit more headroom for the trashcan, so that raising exceptions, calls to instrumentation, sys.audit, etc don't trigger a recursion error. |