Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-131736: only apply security_level workaround in test_ssl for security levels greater than 1 #131739

Merged
merged 3 commits into from
Apr 1, 2025
Merged

gh-131736: only apply security_level workaround in test_ssl for security levels greater than 1 #131739

merged 3 commits into from
Apr 1, 2025

Conversation

WillChilds-Klein
Copy link
Contributor

@WillChilds-Klein WillChilds-Klein commented Mar 25, 2025 •
edited by bedevere-app bot
Loading

Notes

Please see Issue #131736.

Testing

  • CPython CI
  • built locally with AWS-LC, confirmed that relevant tests now work

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Mar 25, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 25, 2025
Closed
@WillChilds-Klein WillChilds-Klein mentioned this pull request Mar 25, 2025
Merged
@vstinner
Copy link
Member

cc @gpshead

@gpshead gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 26, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 1968316 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131739%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 26, 2025
@WillChilds-Klein WillChilds-Klein marked this pull request as ready for review March 26, 2025 21:26
@WillChilds-Klein
Copy link
Contributor Author

Hi @gpshead, thanks for the quick review. Are we waiting on another reviewer or do you think this is ready to merge?

@picnixz picnixz merged commit 3b3720f into python:main Apr 1, 2025
133 checks passed
@picnixz picnixz added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Apr 1, 2025
@miss-islington-app
Copy link

Thanks @WillChilds-Klein for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @WillChilds-Klein for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 1, 2025
@WillChilds-Klein @miss-islington
pythongh-131736: only apply security_level workaround in test_ssl…
d63c5a8 
… for security levels greater than 1 (pythonGH-131739)

(cherry picked from commit 3b3720f)

Co-authored-by: Will Childs-Klein <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Apr 1, 2025

GH-131966 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Apr 1, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 1, 2025
@WillChilds-Klein @miss-islington
pythongh-131736: only apply security_level workaround in test_ssl…
11dcdde 
… for security levels greater than 1 (pythonGH-131739)

(cherry picked from commit 3b3720f)

Co-authored-by: Will Childs-Klein <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Apr 1, 2025

GH-131967 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 1, 2025
@picnixz

This comment was marked as resolved.

Sign in to view
@picnixz picnixz changed the title gh-131736: Only do seclevel workaround if seclevel greater than 1 gh-131736: only apply security_level workaround in test_ssl for security levels greater than 1 Apr 1, 2025
picnixz pushed a commit that referenced this pull request Apr 1, 2025
@miss-islington @WillChilds-Klein
[3.12] gh-131736: only apply security_level workaround in `test_ssl…
756676f 
…` for security levels greater than 1 (GH-131739) (#131966)

gh-131736: only apply `security_level` workaround in `test_ssl` for security levels greater than 1 (GH-131739)
(cherry picked from commit 3b3720f)

Co-authored-by: Will Childs-Klein <[email protected]>
picnixz pushed a commit that referenced this pull request Apr 1, 2025
@miss-islington @WillChilds-Klein
[3.13] gh-131736: only apply security_level workaround in `test_ssl…
05e7fa2 
…` for security levels greater than 1 (GH-131739) (#131967)

gh-131736: only apply `security_level` workaround in `test_ssl` for security levels greater than 1 (GH-131739)
(cherry picked from commit 3b3720f)

Co-authored-by: Will Childs-Klein <[email protected]>
@WillChilds-Klein WillChilds-Klein deleted the guard-seclevel-set branch April 1, 2025 13:43
@WillChilds-Klein WillChilds-Klein mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

@gpshead gpshead gpshead approved these changes

@picnixz picnixz picnixz approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@WillChilds-Klein @vstinner @bedevere-bot @picnixz @gpshead @ZeroIntensity