Skip to content

GH-130415: Remove redundant sym_matches_type calls in the JIT optimizer #131778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Mar 26, 2025

These should already be narrowed by a previous guard. If we made a mistake somewhere, the asserts inside the body of the if will catch it.

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine. After all the uops only occur after a guard.

@brandtbucher brandtbucher merged commit 972a295 into python:main Mar 27, 2025
69 checks passed
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 1, 2025
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news topic-JIT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants