Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-131842: Allow to pass custom CFLAGS and LDFLAGS to the compilation of builtin extension modules #131847

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 28, 2025

@pablogsal
Copy link
Member Author

Does someone has a better name for this flags? I don't like that we have PY_STDMODULE_CFLAGS and PY_STDMODULE_CFLAGS

@pablogsal pablogsal force-pushed the configldflags branch 2 times, most recently from 0cc69ae to f936956 Compare March 28, 2025 15:07
@pablogsal
Copy link
Member Author

I live in the past. I need to move all of this to 3.14 🤦

@vstinner
Copy link
Member

You should add "needs backport to 3.13" label if you want to add this feature to Python 3.13.

@ned-deily
Copy link
Member

ned-deily commented Mar 28, 2025

A terminology question: builtin (or built-in) is used elsewhere to mean linked statically with the interpreter / python library, like here. The intent for this PR is to apply to all standard library extension modules, static and dynamically loaded, right? If so, we should find another word for the variables and descriptions.

@pablogsal
Copy link
Member Author

pablogsal commented Mar 28, 2025

A terminology question: builtin (or built-in) is used elsewhere to mean linked statically with the interpreter / python library, like here. The intent for this PR is to apply to all standard library extension modules, static and dynamically loaded, right? If so, we should find another word for the variables and descriptions.

Agreed. See #131847 (comment)

Any ideas of a better name?

@vstinner
Copy link
Member

Any ideas of a better name?

I suggest to reuse the "extra" term: PY_EXTRA_STDMODULE_CFLAGS and PY_EXTRA_STDMODULE_LDFLAGS.

@pablogsal pablogsal force-pushed the configldflags branch 2 times, most recently from 4c459a4 to 2f61043 Compare March 28, 2025 16:44
…lation of builtin extension modules

Signed-off-by: Pablo Galindo <[email protected]>
@ned-deily
Copy link
Member

I think this PR warrants more discussion. See my comment on the issue.

@pablogsal
Copy link
Member Author

Ok I answered in the issue let's move the discussion there #131842 (comment)

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants