Skip to content

gh-83424: Allow empty name if handle is non-null when create ctypes.CDLL #136878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 5, 2025
Merged

gh-83424: Allow empty name if handle is non-null when create ctypes.CDLL #136878

merged 11 commits into from
Sep 5, 2025
+51 −36

Conversation

aisk
Copy link
Member

@aisk aisk commented Jul 20, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 20, 2025
Open
serhiy-storchaka
serhiy-storchaka reviewed Sep 3, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @aisk. Here are some suggestions.

@aisk aisk marked this pull request as draft September 4, 2025 17:22
@aisk aisk marked this pull request as ready for review September 4, 2025 17:49
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 4, 2025
serhiy-storchaka
serhiy-storchaka approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

zooba
zooba approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder how close we are to splitting this section into separate submodules for different platforms?

@serhiy-storchaka serhiy-storchaka merged commit ed522ed into python:main Sep 5, 2025
55 checks passed
@miss-islington-app
Copy link

Thanks @aisk for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2025
@aisk @miss-islington
pythongh-83424: Allow empty name if handle is non-null when create ct…
cd69a29 
…ypes.CDLL on Windows (pythonGH-136878)

(cherry picked from commit ed522ed211b7b9ea9d85a93b5d6ca79b2df3ef58)

Co-authored-by: AN Long <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2025
@aisk @miss-islington
pythongh-83424: Allow empty name if handle is non-null when create ct…
ec05a63 
…ypes.CDLL on Windows (pythonGH-136878)

(cherry picked from commit ed522ed)

Co-authored-by: AN Long <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 5, 2025

GH-138546 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 5, 2025
@bedevere-app
Copy link

bedevere-app bot commented Sep 5, 2025

GH-138547 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 5, 2025
@aisk aisk deleted the refactor-cdll-constructor branch September 5, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aisk @zooba @serhiy-storchaka